Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds import local VMs documentation #309

Merged
merged 6 commits into from
Dec 17, 2024
Merged

Adds import local VMs documentation #309

merged 6 commits into from
Dec 17, 2024

Conversation

carlosbravoa
Copy link
Contributor

No description provided.

@JessicaJang JessicaJang self-requested a review December 16, 2024 18:24
k-dimple
k-dimple requested changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@k-dimple k-dimple left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits. If they are acceptable, like last time, you can add them to a single commit using the 'Add suggestion to batch' button on the GitHub GUI. Thanks!

.wordlist.txt Outdated
@@ -57,3 +57,4 @@ Jupyter
MLflow
PuTTy
WSL
OVM
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this, since it is no longer used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on hold until we decide about the title "Upload your OVM machine image to S3"

aws/aws-how-to/index.rst Outdated Show resolved Hide resolved
aws/aws-how-to/instances/import-local-vm-to-aws.rst Outdated Show resolved Hide resolved
aws/aws-how-to/instances/import-local-vm-to-aws.rst Outdated Show resolved Hide resolved
aws/aws-how-to/instances/import-local-vm-to-aws.rst Outdated Show resolved Hide resolved
aws/aws-how-to/instances/import-local-vm-to-aws.rst Outdated Show resolved Hide resolved
aws/aws-how-to/instances/import-local-vm-to-aws.rst Outdated Show resolved Hide resolved
aws/aws-how-to/instances/import-local-vm-to-aws.rst Outdated Show resolved Hide resolved
aws/aws-how-to/instances/index.rst Outdated Show resolved Hide resolved
aws/aws-how-to/instances/index.rst Outdated Show resolved Hide resolved
@carlosbravoa @k-dimple
Apply suggestions from code review
08b925c 
Text improvements as suggested by Dimple

Co-authored-by: Dimple Kuriakose <[email protected]>
carlosbravoa
carlosbravoa commented Dec 17, 2024
View reviewed changes
Copy link
Contributor Author

@carlosbravoa carlosbravoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments for further discussion since I am not completely sure.

carlosbravoa
carlosbravoa commented Dec 17, 2024
View reviewed changes
Copy link
Contributor Author

@carlosbravoa carlosbravoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. Changed OVM to OVA and added a link to the "required permissions page"

@k-dimple k-dimple merged commit 2b2a647 into canonical:main Dec 17, 2024
1 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-dimple k-dimple k-dimple approved these changes

@JessicaJang JessicaJang Awaiting requested review from JessicaJang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosbravoa @JessicaJang @k-dimple